Use registry to find linked batteries for homekit #33519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
balloob
reviewed
Apr 2, 2020
balloob
reviewed
Apr 2, 2020
balloob
reviewed
Apr 2, 2020
|
Will come back to this on the weekend when I have a larger chunk of time. |
|
I'm going to come back to this once all the homekit PRs I have pending review are merged to avoid the conflict |
bdraco
force-pushed
the
homekit_find_linked_batteries
branch
from
79dcaf9
to
96304da
Compare
|
Fixed all the conflicts, now going to do a break out of binary sensor for the arch change. Then I'll add a lot more tests and optimize. |
bdraco
force-pushed
the
homekit_find_linked_batteries
branch
6 times, most recently
from
ee6a301
to
e71c2e1
Compare
bdraco
force-pushed
the
homekit_find_linked_batteries
branch
from
cc9e26b
to
be6504f
Compare
|
I wanted another device to test this with so I added vacuum support so I could test with my roomba #34386 |
bdraco
force-pushed
the
homekit_find_linked_batteries
branch
3 times, most recently
from
8923ec1
to
4db9daa
Compare
bdraco
force-pushed
the
homekit_find_linked_batteries
branch
2 times, most recently
from
84c1c55
to
d305b58
Compare
bdraco
force-pushed
the
homekit_find_linked_batteries
branch
from
d305b58
to
0bad701
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
suppress homekit state updates after changing state from homekit as unexpected event was fixed in HAP-python 2.7.0+
bdraco
force-pushed
the
homekit_find_linked_batteries
branch
from
0bad701
to
74c47af
Compare
balloob
approved these changes
Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Battery level is found in the following order:
Battery charging state is found in the following order:
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: